Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper schema.org types #7

Open
NoelDeMartin opened this issue Feb 21, 2020 · 1 comment
Open

Use proper schema.org types #7

NoelDeMartin opened this issue Feb 21, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@NoelDeMartin
Copy link

I've been looking into the use of the schema.org vocabulary and there are a couple of things that are not consistent with the documentation. In particular:

  • The http://schema.org/review property is being used on a http://schema.org/WatchAction. As documented here, an Action is not a proper subject for this property.
  • The http://schema.org/starRating property is being used on a http://schema.org/Review. I think this may have been a mistyping, the proper property for a Review is http://schema.org/reviewRating.
@pheyvaer
Copy link
Owner

pheyvaer commented Mar 6, 2020

Hi @NoelDeMartin

Thanks for the issue! Yeah I quickly looked at both things you mentioned and I think you are right. I would like at some point to update this application and will then incorporate your changes.

@pheyvaer pheyvaer added the bug Something isn't working label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants