Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch: ruler-picker-updates #107

Open
dubson opened this issue Jun 29, 2015 · 6 comments
Open

branch: ruler-picker-updates #107

dubson opened this issue Jun 29, 2015 · 6 comments

Comments

@dubson
Copy link

dubson commented Jun 29, 2015

Modifying WOAS to improve appearance of rulers and pickers. For AP's approval.

@dubson dubson self-assigned this Jun 29, 2015
@dubson
Copy link
Author

dubson commented Jun 29, 2015

I wish to alter the appearance of the rulers and pickers on WOAS. In preparing sim primer, I find the need for minor changes. I have conferred with KP and JO already, and have their approval. I have prepared a dev version of WOAS with the changes (1.0.1). The changes are:

  1. rulers are now in front (not behind) so you can see the tic mark when you are measuring distance.
  2. rulers have tic marks every 1 mm ( not every 2mm) for more precise measurements
  3. rulers are somewhat more narrow (so not so heavy-looking)
  4. rulers are partially transparent, so can see through
  5. pickers on sliders are somewhat smaller, so not so heavy looking.
    Await comments/approval from AP.

@ariel-phet
Copy link

Changes look great to me. We of course should get the sim tested before releasing this version.

@dubson
Copy link
Author

dubson commented Jun 29, 2015

Ok, thanks!!

@pixelzoom pixelzoom changed the title Branch: ruler-picker-updates branch: ruler-picker-updates Aug 13, 2015
@pixelzoom
Copy link
Contributor

Looks like @ariel-phet approved the changes. Have they been merged back into master? Can this branch be deleted? If not, what are the plans for this branch?

@ariel-phet
Copy link

@pixelzoom - since @dubson was planning to use this version for the sim primer, I assume the plan would be to make this the main version to test when we deploy

@pixelzoom
Copy link
Contributor

@ariel-phet wrote:

I assume the plan would be to make this the main version to test when we deploy

We do not deploy out of branches like this, we deploy by branching master. Do you mean that the plan in to merge these changes into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants