Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreferenced global in DB2Sequence>>#name: #140

Open
astares opened this issue Jul 15, 2023 · 3 comments
Open

Unreferenced global in DB2Sequence>>#name: #140

astares opened this issue Jul 15, 2023 · 3 comments
Labels

Comments

@astares
Copy link
Contributor

astares commented Jul 15, 2023

image

@astares astares added the bug label Jul 15, 2023
@astares
Copy link
Contributor Author

astares commented Jul 15, 2023

This is a bug for DB2 support only then (which is incomplete anyway)
We should refactor specific DB support in separate loadable packages

@JoachimTuchel
Copy link

While I agree on the separate loadable packages, I want to add a comment on the method's way of operation in general (completely unrelated, btw):
I don't think it is good practice to truncate the name of a table or sequence, even if the limit is ridiculously high (128 in case of DB2). I'd rather be notified by an exception that I am doing something wrong here. But as I said, unrelated to the issue at hand.

@JoachimTuchel
Copy link

... and I don't like the fact that such a constant value is retrieved from an instance method. Is it really necessary to create an instance of the DB2Platform just to ask it for a number that is a global value (=class side)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants