Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete showSpace: in BlElement and BlSpace? #698

Closed
tinchodias opened this issue Feb 12, 2025 · 0 comments · Fixed by #703
Closed

Delete showSpace: in BlElement and BlSpace? #698

tinchodias opened this issue Feb 12, 2025 · 0 comments · Fixed by #703

Comments

@tinchodias
Copy link
Collaborator

There are 2 implementors of showSpace: but zero senders. I have not only Bloc and Toplo loaded, also Pyramid and other projects loaded in my image.

Implementor in BlSpace:

showSpace: aSpace
	"I show a given space either inside of me or let it open by default"
	aSpace show

In BlElement:

showSpace: aSpace
	self hasParent
		ifTrue: [ self parent showSpace: aSpace ]
		ifFalse: [
			self isAttachedToSceneGraph
				ifTrue: [ self space showSpace: aSpace ]
				ifFalse: [ aSpace show ] ]

It seems the intention is to support a scenario of inner vs independent windows, via hooks (overriding one of such implementors).

Do you have an opinion @plantec ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete showSpace: in BlElement and BlSpace pharo-graphics/Bloc
1 participant
@tinchodias