Skip to content

Commit bcafbb2

Browse files
committed
Add missing #close (locally, I have a deeper refactoring)
1 parent e8d4277 commit bcafbb2

2 files changed

Lines changed: 46 additions & 36 deletions

File tree

src/Bloc-Scripter/BlDevScripter.class.st

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,17 @@ BlDevScripter >> assertSpace: aSpace [
5858
description: [ 'Space must be initialized before the element ', self element printString ]
5959
]
6060

61+
{ #category : #'api - lifecycle' }
62+
BlDevScripter >> close [
63+
64+
space ifNotNil: [
65+
| aUniverse |
66+
aUniverse := space universe.
67+
space close.
68+
aUniverse tryToRunDeferredActions.
69+
space := nil ]
70+
]
71+
6172
{ #category : #execution }
6273
BlDevScripter >> continue [
6374
BlDevScripterStepContinueExecutor new
Lines changed: 35 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
"
2-
I exemplify `BlDevScripter`.
3-
4-
"
51
Class {
62
#name : #BlDevScripterTest,
73
#superclass : #TestCase,
4+
#instVars : [
5+
'scripter'
6+
],
87
#category : #'Bloc-Scripter-Examples'
98
}
109

@@ -32,74 +31,74 @@ BlDevScripterTest >> newContainerWithRectangle [
3231
BlDevScripterTest >> newRectangle [
3332

3433
^ BlElement new
35-
extent: 100 @ 100;
36-
background: Color gray;
37-
border: (BlBorder paint: Color black width: 2);
34+
background: Color red;
3835
constraintsDo: [ :c |
3936
c frame vertical alignCenter.
4037
c frame horizontal alignCenter ];
4138
yourself
4239
]
4340

41+
{ #category : #running }
42+
BlDevScripterTest >> setUp [
43+
44+
super setUp.
45+
scripter := BlDevScripter new.
46+
scripter element: self newContainerWithRectangle
47+
]
48+
49+
{ #category : #running }
50+
BlDevScripterTest >> tearDown [
51+
52+
scripter close.
53+
super tearDown
54+
]
55+
4456
{ #category : #tests }
4557
BlDevScripterTest >> testClickCheckFailure [
4658

47-
| anElement aScripter found |
48-
anElement := self newContainerWithRectangle.
49-
aScripter := BlDevScripter new.
50-
aScripter element: anElement.
51-
59+
| found |
5260
"Expect a click on the first child.
5361
But will do a click on the space's root"
54-
aScripter testClick onSpaceRoot.
55-
aScripter check testClick onChildAt: 1.
62+
scripter click onSpaceRoot.
63+
scripter check click onChildAt: 1.
5664

57-
self should: [ aScripter syncPlay ] raise: AssertionFailure.
65+
self should: [ scripter syncPlay ] raise: AssertionFailure.
5866

5967
"The root is the clicked element"
6068
found := false.
61-
aScripter events
69+
scripter events
6270
detect: [ :each | each isClick ]
6371
ifFound: [ :event |
6472
found := true.
65-
self assert: event target equals: anElement space root ]
73+
self assert: event target equals: scripter element space root ]
6674
ifNone: [ self fail ].
6775
self assert: found
6876
]
6977

7078
{ #category : #tests }
7179
BlDevScripterTest >> testClickCheckSuccess [
7280

73-
| anElement aScripter found |
74-
anElement := self newContainerWithRectangle.
75-
aScripter := BlDevScripter new.
76-
aScripter element: anElement.
77-
78-
aScripter testClick onChildAt: 1.
79-
aScripter check testClick onChildAt: 1.
80-
aScripter syncPlay.
81+
| found |
82+
scripter click onChildAt: 1.
83+
scripter check click onChildAt: 1.
84+
scripter syncPlay.
8185

8286
found := false.
83-
aScripter events
87+
scripter events
8488
detect: [ :each | each isClick ]
8589
ifFound: [ :event |
8690
found := true.
87-
self assert: event target equals: (anElement childAt: 1) ]
91+
self assert: event target equals: (scripter element childAt: 1) ]
8892
ifNone: [ self fail ].
8993
self assert: found
9094
]
9195

9296
{ #category : #tests }
9397
BlDevScripterTest >> testSyncPlayProducesClick [
9498

95-
| anElement aScripter |
96-
anElement := self newContainerWithRectangle.
97-
aScripter := BlDevScripter new.
98-
aScripter element: anElement.
99-
100-
aScripter testClick onChildAt: 1.
99+
scripter click onChildAt: 1.
101100

102-
self assert: aScripter events isEmpty.
103-
aScripter syncPlay.
104-
self assert: (aScripter events asArray anySatisfy: [ :each | each isClick ])
101+
self assert: scripter events isEmpty.
102+
scripter syncPlay.
103+
self assert: (scripter events asArray anySatisfy: [ :each | each isClick ])
105104
]

0 commit comments

Comments
 (0)