Move BlSpace class >> #extractRoots: into its sole sender; deprecate the originals

Author: tinchodias

src/Bloc/BlElementBoundsUpdater.class.st

@@ -38,19 +38,25 @@ BlElementBoundsUpdater >> commitChanges [
 		               thenCollect: [ :eachAssociation | eachAssociation key ].
 	theElements ifEmpty: [ ^ self ].
 
-	"<---"
-	self flag: 'Workarroud: avoiding #extractRoots: use speed-up position updates a lot'.
-	"theElements do: [ :eachRootElement |
-		eachRootElement withAllChildrenBreadthFirstDo: [ :eachChild |	eachChild onPositionInSpaceChanged ] ]."
-	"--->"
-	self flag: 'Original version'.
-	"<---"
-	self flag: ' It sounds better with #extractRoots: from feenk '.
-	theRoots := BlSpace extractRoots: theElements.
+	theRoots := self extractRoots: theElements.
 	theRoots do: [ :eachRootElement |
 		eachRootElement withAllChildrenBreadthFirstDo: [ :eachChild | eachChild onPositionInSpaceChanged ] ]
-	"--->"
+]
 
+{ #category : #'private - changes' }
+BlElementBoundsUpdater >> extractRoots: aSetOfElements [
+	| roots |
+	roots := IdentitySet withAll: aSetOfElements.
+	aSetOfElements do: [ :each | 
+		| current |
+		current := each parent.
+		[ current isNil ] whileFalse: [
+			(roots includes: current)
+				ifTrue: [ 
+					roots remove: each ifAbsent: [  ].
+					current := nil ]
+				ifFalse: [ current := current parent ] ] ].
+	^ roots
 ]
 
 { #category : #testing }

src/Bloc/BlSpace.class.st

@@ -36,7 +36,6 @@ Class {
 		'focusChain',
 		'pulseRequested',
 		'currentCursor',
-		'session',
 		'focused',
 		'title',
 		'fullscreen',
@@ -64,23 +63,11 @@ BlSpace class >> defaultRootLabel [
 
 { #category : #'private - change' }
 BlSpace class >> extractRoots: aSetOfElements [
-	| roots |
-	" feenk version 2022-02-01 that eliminate recursion from allParentsDo: "
-	
-	roots := IdentitySet withAll: aSetOfElements.
-	aSetOfElements
-		do:
-			[ :each | 
-			| current |
-			current := each parent.
-			[ current isNil ]
-				whileFalse:
-					[ (roots includes: current)
-						ifTrue:
-							[ roots remove: each ifAbsent: [  ].
-							current := nil ]
-						ifFalse: [ current := current parent ] ] ].
-	^ roots
+	self
+		deprecated: 'Use BlElementBoundsUpdater >> #extractRoots: instead'
+		transformWith: '`@receiver extractRoots: `@arg' -> 'BlElementBoundsUpdater new extractRoots: `@arg'.
+
+	^ BlElementBoundsUpdater new extractRoots: aSetOfElements
 ]
 
 { #category : #'debug - simulation' }
@@ -897,6 +884,10 @@ BlSpace >> extent: aNewExtent [
 
 { #category : #'private - change' }
 BlSpace >> extractRoots: aSetOfElements [
+	self
+		deprecated: 'Use BlElementBoundsUpdater >> #extractRoots: instead'
+		transformWith: '`@receiver extractRoots: `@arg' -> 'BlElementBoundsUpdater new extractRoots: `@arg'.
+
 	^ self class extractRoots: aSetOfElements
 ]