Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Issue: Verify template results #2506

Open
StefanThoma opened this issue Sep 12, 2024 · 6 comments
Open

General Issue: Verify template results #2506

StefanThoma opened this issue Sep 12, 2024 · 6 comments

Comments

@StefanThoma
Copy link
Collaborator

Background Information

It would be ideal to have a way to verify whether the outputs of the templates have changed.

One idea would be to write unit tests, so that running the unit tests would already check that.
I think it could be done like this in a unit test:

  1. Create new file using template
  2. (Potentially) modify the new file to reduce the dataset size used
  3. Source the file
  4. Compare the newly created file to the one created last time using diffdf

Definition of Done

Either find a way of verifying the outputs of the templates, or to decide that this is not necessary.

@bms63
Copy link
Collaborator

bms63 commented Sep 12, 2024

I would be hesitant to make these into unit tests as they are very big files to run.

The current CI check for the templates is a separate workflow. I was thinking we would build off that one - pharmaverse/admiralci/.github/workflows/check-templates.yml@main

@StefanThoma
Copy link
Collaborator Author

I see your point.
The downside with a separate run is that you cannot run it locally, afaik.

@bms63
Copy link
Collaborator

bms63 commented Sep 12, 2024

What about how Edoardo approached that new check in the blog? He sources a file in the workflow - maybe something to consider? Then you could grab the file and run it

@StefanThoma
Copy link
Collaborator Author

Yeah that would not be a bad idea. Let me experiment a bit.

@bundfussr
Copy link
Collaborator

The downside with a separate run is that you cannot run it locally, afaik.

We could implement a function which runs a specified list of templates and compares the results with the references datasets (in pharmaverseadam?).

This function could then be used in the CI/CD workflow and also be called locally.

@StefanThoma
Copy link
Collaborator Author

The downside with a separate run is that you cannot run it locally, afaik.

We could implement a function which runs a specified list of templates and compares the results with the references datasets (in pharmaverseadam?).

This function could then be used in the CI/CD workflow and also be called locally.

That sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants