Handle missing parameter names returned from ReflectionParameter #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20uf
approved these changes
Jul 7, 2018
|
I'm closing this PR since it's an old one and Phake v2 is not supported anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259
I based this off the v2.3.2 tag - sorry I couldn't figure out which branch belonged to the stable branches (master requires PHP 7+ which is too new for us, i.e we're support PHP 5.4 - 7.1 still).
The way I'm testing
copyMethodParametersis pretty dodgy, but I couldn't come up with anything better, feedback welcome.