Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a ThinCStr type #1730

Open
workingjubilee opened this issue Jun 3, 2024 · 1 comment
Open

Use a ThinCStr type #1730

workingjubilee opened this issue Jun 3, 2024 · 1 comment
Labels
enhancement New feature or request ffi-bindgen ffi-safety

Comments

@workingjubilee
Copy link
Member

workingjubilee commented Jun 3, 2024 •
edited
Loading

Relatively simple.

Pick or write a ThinCStr type (or Thin<CStr>, whatever). and rewrite most/all *const c_char args in pgrx-pg-sys bindings to take it. In practice they generally want to be pointers to null terminated strings.
@workingjubilee
Copy link
Member Author

workingjubilee commented Jun 3, 2024 •
edited
Loading

more ambitious: get upstream to finally implement size_of::<&CStr>() == size_of::<*const c_char>() like they have been threatening to do Forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ffi-bindgen ffi-safety
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@workingjubilee