Skip to content

Hashed-based approach sharding key type #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Denchick opened this issue Nov 22, 2024 · 0 comments
Open

Hashed-based approach sharding key type #836

Denchick opened this issue Nov 22, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Denchick
Copy link
Collaborator

There is no "HASH" keyword in the "ALTER DISTRIBUTION" command definition. Therefore, when using a key-range-based approach, we use the int64 golang type, but when using a hash-based approach, the underlying type becomes uint32, which leads to confusion.

What should we do?

  • Update or documentation
  • Introduce new uint type (should be the underlying type uint32 or uint64?)
  • Forbid using int type for hash-based approach
@Denchick Denchick added enhancement New feature or request help wanted Extra attention is needed labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Denchick