Skip to content

Commit e787c42

Browse files
committed
Send a REQ_NEW_WINDOW for new windows
Allows for NEW_TAB to be used instead in uzbl-tabbed.
1 parent 66276ec commit e787c42

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1390,7 +1390,7 @@ uzbl itself and will be emitted based on what is happening within uzbl-core.
13901390
- Sent when the geometry changes.
13911391
* `WEBINSPECTOR <open|close>`
13921392
- Sent when the web inspector window is opened or closed.
1393-
* `NEW_WINDOW <URI>`
1393+
* `REQ_NEW_WINDOW <URI>`
13941394
- Sent when a new window is being requested.
13951395
* `CLOSE_WINDOW`
13961396
- Sent when `uzbl` is closing its window.

UPGRADING.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,12 @@ for these events. Also check the event manager for built-in handlers.
280280
- *Rationale*: The data is available and may be useful.
281281
- *Porting*: Expect a second argument in any `LINK_HOVER` event
282282
handlers.
283+
* `NEW_WINDOW`
284+
- *Change*: Renamed to `REQ_NEW_WINDOW`.
285+
- *Rationale*: Replaced with `REQ_NEW_WINDOW` for better interoperability
286+
with `uzbl-tabbed`.
287+
- *Porting*: Chain `REQ_NEW_WINDOW` to `NEW_WINDOW` or `NEW_TAB` depending on
288+
the application.
283289
* `SELECTION_CHANGED`
284290
- *Change*: Removed.
285291
- *Rationale*: This is no longer a builtin event. It was previously

src/events.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
call (TITLE_CHANGED), \
2323
call (GEOMETRY_CHANGED), \
2424
call (WEBINSPECTOR), \
25-
call (NEW_WINDOW), \
25+
call (REQ_NEW_WINDOW), \
2626
call (CLOSE_WINDOW), \
2727
call (VARIABLE_SET), \
2828
call (FIFO_SET), \

src/gui.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2610,7 +2610,7 @@ create_web_view_uri_cb (WebKitWebView *view, GParamSpec param_spec, gpointer dat
26102610
uzbl_commands_run_argv ("js", args, NULL);
26112611
uzbl_commands_args_free (args);
26122612
} else {
2613-
uzbl_events_send (NEW_WINDOW, NULL,
2613+
uzbl_events_send (REQ_NEW_WINDOW, NULL,
26142614
TYPE_STR, uri,
26152615
NULL);
26162616
}

0 commit comments

Comments
 (0)