Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lost-column: none; always generates float-specific CSS, regardless of global flexbox setting #424

Open
brandondurham opened this issue Oct 16, 2018 · 1 comment

Comments

@brandondurham
Copy link

Is this a feature request or a bug report?
Bug.

What is the current behavior?
Using lost-column: none; to reset a Lost element results in float-specific CSS being generated, even when the global setting is set to flex.

If it's a bug please provide the steps to reproduce it and maybe some code samples.

  1. Add the @lost flexbox flex global setting so that any elements with lost-column use flexbox.
  2. Add a lost-flex-container row with any number of lost-managed flex elements with ``lost-column: /;`.
  3. For one of those elements, use lost-column: none; to reset lost-related properties.
  4. You should see the CSS generated for that element is for float columns, not flex columns.

What is the desired behavior?
Using lost-column: none; on any element will generate css that’s based on global settings.

What version of LostGrid, browser and browser version are affected by this issue? Did this happen in previous versions?
v8.3.0

Anything else?
I set up a repo illustrating the issue: https://github.com/brandondurham/lost-reset

  1. Download
  2. cd into the directory
  3. run yarn or npm install
  4. run yarn start or npm start

There is also a simple example online here: https://lost-reset-bug-sbjzudyxpz.now.sh/

@peterramsing
Copy link
Owner

Ooo. Yup. I let that escape. Let me get a failing test for this on a branch and see if I can tackle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants