Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional examples for MVC controllers #211

Open
hefox opened this issue Feb 15, 2017 · 1 comment
Open

Add additional examples for MVC controllers #211

hefox opened this issue Feb 15, 2017 · 1 comment

Comments

@hefox
Copy link

hefox commented Feb 15, 2017

Hiya!

I'm new to express/node development and decided to use this generator to get me started. One major pain point I had was figuring out how to structure the router calls, as all the examples I found was using a single file for all the router files.

I eventually figured out adding the same exports statement worked, after I spent a lot of time trying varients of app.use(/'some-path'). I'm not sure this is ideal, not sure the inner workings of app.use.

`
module.exports = function (app) {
app.use('/', router);
};

router.get('/sometpath', function (req, res, next) {
...
});
`

I suspect if I'd did app.use('/somepath', router); with router.get('/', but haven't tested yet.

I propose adding a article controller with example router paths. I'm willing to work on a PR but figured I'd gauge interest first.

@petecoop
Copy link
Owner

Hey, yeah I think you worked it out. The app.use sets the base route for the controller, then router.get is after that, so yes you could do app.use('/somepath', then router.get('/' to get the same thing.

hefox added a commit to hefox/generator-express that referenced this issue Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants