Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'NewContract' object has no attribute '_expression #151

Closed
julianmrodri opened this issue Apr 12, 2024 · 4 comments · Fixed by #152
Closed

AttributeError: 'NewContract' object has no attribute '_expression #151

julianmrodri opened this issue Apr 12, 2024 · 4 comments · Fixed by #152
Assignees
Labels
bug Something isn't working

Comments

@julianmrodri
Copy link

julianmrodri commented Apr 12, 2024

Hi, we are facing the following error in our codebase ("AttributeError: 'NewContract' object has no attribute '_expression'") . This is caused by a Slitherin detector because if I run with the separate param the Slither parts finishes successfully and the failure is on the Slitherin side.

Any idea what could cause this? Older branches of our codebase finish successfully so its something in our current branches that cannot be parsed correctly I believe.

Versions: slither 0.10.1, and slitherin 0.6.1

The issue is strange_setter. I can provide details on how to replicate with our repo which is public. Let me know if that helps.. If I run it with slitherin . --exclude pess-strange-setter it finishes successfully.

image
@olegggatttor
Copy link
Contributor

I will have a look into it, thanks

@olegggatttor olegggatttor added the bug Something isn't working label Apr 12, 2024
@olegggatttor olegggatttor self-assigned this Apr 12, 2024
@julianmrodri
Copy link
Author

julianmrodri commented Apr 12, 2024

I will have a look into it, thanks

Was able to narrow it to the strange-setter detector. All the other seem to work fine. Let me know if you want instructions on how to replicate on our codebase. Thanks!!

@julianmrodri
Copy link
Author

I can confirm I was able to run all the detectors on my codebase after this change. Its not breaking anymore on strange-setter Do you have en estimate on this change will be published/released? Thanks a lot!

@ndkirillov
Copy link
Collaborator

@julianmrodri, released with #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants