Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove imports that export unscanned targets #804

Open
ileitch opened this issue Aug 23, 2024 · 0 comments
Open

Don't remove imports that export unscanned targets #804

ileitch opened this issue Aug 23, 2024 · 0 comments
Labels
bug A bug in Periphery

Comments

@ileitch
Copy link
Contributor

ileitch commented Aug 23, 2024

It's not safe to remove an import for a module that exports (possibly transitively) any unscanned module, as the symbols from the unscanned module may be referenced.

Display warning when this scenario is detected?
@ileitch ileitch added this to the v3 milestone Aug 23, 2024
@ileitch ileitch added the bug A bug in Periphery label Dec 18, 2024
@ileitch ileitch removed this from the v3 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug in Periphery
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ileitch