Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis error with cometbft v1.0.0 #58

Open
larry0x opened this issue Dec 25, 2024 · 1 comment
Open

Genesis error with cometbft v1.0.0 #58

larry0x opened this issue Dec 25, 2024 · 1 comment

Comments

@larry0x
Copy link

larry0x commented Dec 25, 2024

tower-abci works well with cometbft v0.38.16, but with v1.0.0:

2024-12-25T18:25:44.415872Z  INFO tower_abci::v038::server: ABCI server starting on tcp socket addr=127.0.0.1:26658
2024-12-25T18:25:48.350124Z  INFO tower_abci::v038::server: listening for requests
2024-12-25T18:25:48.350790Z  INFO tower_abci::v038::server: listening for requests
2024-12-25T18:25:48.350970Z  INFO tower_abci::v038::server: listening for requests
2024-12-25T18:25:48.351123Z  INFO tower_abci::v038::server: listening for requests
thread 'tokio-runtime-worker' panicked at /Users/larry/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tower-abci-0.18.0/src/v038/server.rs:173:75:
called `Result::unwrap()` on an `Err` value: missing public key

Location:
    /Users/larry/.cargo/registry/src/index.crates.io-6f17d22bba15001f/flex-error-0.4.4/src/tracer_impl/eyre.rs:10:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This happens when starting a chain fresh from genesis. If I start a chain with 0.38, kill it, then restart with 1.0.0, the chain can carry on normally.

@erwanor
Copy link
Member

erwanor commented Dec 25, 2024

Interesting, by default, I would expect the v038 protocol to carry over v1 nicely, but this is actually encouraging. I don't see any published domain types in either tendermint-rs or cometbft-rs, but:

However, the published version of cometbft-rs on crates.io is empty: https://docs.rs/cometbft/latest/cometbft/

At least the protos are published on buf, so I can give this a deeper look very soon and figure it out. I think we can add support soon after domain types become available. We might have to write them, but that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants