pcli: tx lp withdraw <position>
#5069
Assignees
Comments
conorsch
pushed a commit
that referenced
this issue
Feb 21, 2025
## Describe your changes Now we can use `pcli tx withdraw <id>` to withdraw a position multiple times, increasing its sequence. We fetch the reserves on every try so that the balance commitment is always accurate. To view the output, use `pcli v balance --by-note` this is unfortunate but wontfix now. ## Issue ticket number and link #5069 ## Checklist before requesting a review - [ ] I have added guiding text to explain how a reviewer should test these changes. - [ ] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > REPLACE THIS TEXT WITH RATIONALE (CAN BE BRIEF) --------- Co-authored-by: Lucas Meier <[email protected]>
conorsch
pushed a commit
that referenced
this issue
Feb 21, 2025
## Describe your changes Now we can use `pcli tx withdraw <id>` to withdraw a position multiple times, increasing its sequence. We fetch the reserves on every try so that the balance commitment is always accurate. To view the output, use `pcli v balance --by-note` this is unfortunate but wontfix now. ## Issue ticket number and link #5069 ## Checklist before requesting a review - [ ] I have added guiding text to explain how a reviewer should test these changes. - [ ] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > REPLACE THIS TEXT WITH RATIONALE (CAN BE BRIEF) --------- Co-authored-by: Lucas Meier <[email protected]>
cronokirby
added a commit
that referenced
this issue
Feb 27, 2025
## Describe your changes Now we can use `pcli tx withdraw <id>` to withdraw a position multiple times, increasing its sequence. We fetch the reserves on every try so that the balance commitment is always accurate. To view the output, use `pcli v balance --by-note` this is unfortunate but wontfix now. ## Issue ticket number and link #5069 ## Checklist before requesting a review - [ ] I have added guiding text to explain how a reviewer should test these changes. - [ ] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > REPLACE THIS TEXT WITH RATIONALE (CAN BE BRIEF) --------- Co-authored-by: Lucas Meier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We can withdraw a position multiple times using
pcli.Each time, the sequence number of the position increases.
We query the remote RPC to fetch the latest for the position so that we always compute an accurate balance commitment. This is important to do because the funding component will deposit rewards into that position, and our state might be stale.
The text was updated successfully, but these errors were encountered: