-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add workflow for crate publishing #5005
Comments
Still not done; for |
As part of the For the crate ownership, I've started sending invites via API to adjust the setup, will comment when that's complete. |
Not quite: the job failed with error:
which is due to the way github checks out gitrefs in CI contexts: we're not simply using the "main" branch in that context, even though that's where the tag was made. |
Modifies the `cargo-release` config to permit releasing from the `HEAD` checkout created by GHA in CI. By default, cargo-release disallows `HEAD` via the `!HEAD` match, see docs at [0]. Refs #5005. [0] https://github.com/crate-ci/cargo-release/blob/f7c2975325afc6d6fc1793544802a5578d9ef256/docs/reference.md
## Describe your changes Modifies the `cargo-release` config to permit releasing from the `HEAD` checkout created by GHA in CI. By default, cargo-release disallows `HEAD` via the `!HEAD` match, see docs at [0]. [0] https://github.com/crate-ci/cargo-release/blob/f7c2975325afc6d6fc1793544802a5578d9ef256/docs/reference.md ## Issue ticket number and link Refs #5005. ## Testing and review I need this change to land on main in order for it to be active in the release workflow. Shortly I'll publish 1.2.0 and observe behavior then. As long as CI is green on this PR, we're good to merge, then I'll follow up on next steps. ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > CI/release logic only, no changes to app code
Sick, looks like the latest version completed successfully in CI: https://github.com/penumbra-zone/penumbra/actions/runs/13687172377 |
Following up on the work to publish the workspace code to crates.io (#4978), we should add a CI workflow to automate that process. That work entails:
./deployments/scripts/publish-crates
Once that's handled, the crate publishing will happen automatically as part of our existing release process.
The text was updated successfully, but these errors were encountered: