Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Letter spacing for text is not being correctly applied when importing a .zip without position-data #4533

Open
Cenadros opened this issue Apr 29, 2024 · 0 comments
Labels

Comments

@Cenadros
Copy link
Contributor

Cenadros commented Apr 29, 2024

Steps To Reproduce

We're working in the https://github.com/penpot/penpot-exporter-figma-plugin and we've generated a .zip file from Figma containing a text node with all the information given in the content. Although the letter-spacing is being imported, it's not being rendered.

The steps to reproduce are these:

  1. You can try from the main branch of the penpot-exporter or download the generated .zip. If you use the attached .zip you can jump to step 6.
  2. Build the plugin with node 20 (npm run build)
  3. Import the plugin in FIgma using the manifest.json.
  4. Create a text node in Figma and assign a letter space (you can do it in px or % but it's easier to see the translation in px)
  5. Use the plugin to export the file.
  6. Import the generated file into Penpot

Expected behavior

The letter spacing being imported through text content should be rendered correctly.

Actual behavior

The letter spacing is being imported but it's not being rendered until you modify the property in Penpot.

Screenshots or video

The imported file with 50px of letter spacing but not rendered:
image

The same text with correct 50px of letter spacing after modifying it:
image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Environment (please complete the following information)

No response

Frontend Stack Trace

No response

Backend Stack Trace

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant