Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Holding shift doesn't change the expected 10 steps for all color value inputs #4513

Open
pr0pz opened this issue Apr 24, 2024 · 3 comments
Labels
bug good first issue self-hosted The issue is happening on a self-hosted instance

Comments

@pr0pz
Copy link

pr0pz commented Apr 24, 2024

Steps To Reproduce

  1. Start self hosted version with docker compose
  2. Open any project or create a new one
  3. Create a rectangle element
  4. Click on the current fill color to open up color panel
  5. Click on any color input field (R, G, B, Alpha, H, S, V, etc.)
  6. Hold Shift and tap Arrow Up/Down

Expected behavior

I expect every value to jump 10th steps while holding shift.

Actual behavior

The values jump only 1 step at a time while holding shift.

Screenshots or video

penpot-color_change_shift_10.mp4

Desktop (please complete the following information)

  • OS: macos sonoma 14.4.1
  • Browser: Arc 1.39.1

Smartphone (please complete the following information)

No response

Environment (please complete the following information)

Self-Hosted:

  • OS: macos sonoma 14.4.1
  • Docker Desktop: 4.28.0 (139021)
  • Compose: v2.24.6-desktop.1
docker-compose.yaml
---
version: "3.5"

networks:
  penpot:

volumes:
  penpot_postgres_v15:
  penpot_assets:

services:
  penpot-frontend:
    image: "penpotapp/frontend:latest"
    restart: always
    ports:
      - 9001:80

    volumes:
      - penpot_assets:/opt/data/assets

    depends_on:
      - penpot-backend
      - penpot-exporter

    networks:
      - penpot

    labels:
      - "traefik.enable=true"

    environment:
      - PENPOT_FLAGS=enable-registration enable-login-with-password

  penpot-backend:
    image: "penpotapp/backend:latest"
    restart: always

    volumes:
      - penpot_assets:/opt/data/assets

    depends_on:
      - penpot-postgres
      - penpot-redis

    networks:
      - penpot
    environment:
      - PENPOT_FLAGS=enable-registration enable-login-with-password disable-email-verification enable-smtp enable-prepl-server
      - PENPOT_PUBLIC_URI=http://localhost:9001
      - PENPOT_DATABASE_URI=postgresql://penpot-postgres/penpot
      - PENPOT_DATABASE_USERNAME=penpot
      - PENPOT_DATABASE_PASSWORD=penpot
      - PENPOT_REDIS_URI=redis://penpot-redis/0
      - PENPOT_ASSETS_STORAGE_BACKEND=assets-fs
      - PENPOT_STORAGE_ASSETS_FS_DIRECTORY=/opt/data/assets
      - PENPOT_TELEMETRY_ENABLED=true
      - [email protected]
      - [email protected]
      - PENPOT_SMTP_HOST=penpot-mailcatch
      - PENPOT_SMTP_PORT=1025
      - PENPOT_SMTP_USERNAME=
      - PENPOT_SMTP_PASSWORD=
      - PENPOT_SMTP_TLS=false
      - PENPOT_SMTP_SSL=false

  penpot-exporter:
    image: "penpotapp/exporter:latest"
    restart: always
    networks:
      - penpot

    environment:
      - PENPOT_PUBLIC_URI=http://penpot-frontend
      - PENPOT_REDIS_URI=redis://penpot-redis/0

  penpot-postgres:
    image: "postgres:15"
    restart: always
    stop_signal: SIGINT

    volumes:
      - penpot_postgres_v15:/var/lib/postgresql/data

    networks:
      - penpot

    environment:
      - POSTGRES_INITDB_ARGS=--data-checksums
      - POSTGRES_DB=penpot
      - POSTGRES_USER=penpot
      - POSTGRES_PASSWORD=penpot

  penpot-redis:
    image: redis:7
    restart: always
    networks:
      - penpot

  penpot-mailcatch:
    image: sj26/mailcatcher:latest
    restart: always
    expose:
      - '1025'
    ports:
      - "1080:1080"
    networks:
      - penpot

Frontend Stack Trace

No response

Backend Stack Trace

No response

Additional context

No response

@pr0pz pr0pz added the bug label Apr 24, 2024
@myfunnyandy
Copy link
Contributor

myfunnyandy commented Apr 25, 2024

Hi @pr0pz,

This is not technically a bug, as it never has been required to work like that, but it is definitely a great suggestion. I've added it as an enhancement to our roadmap, including a reference to this issue, so it could be a candidate for our future prioritizations: https://tree.taiga.io/project/penpot/issue/7606

@pr0pz
Copy link
Author

pr0pz commented Apr 25, 2024

Haha ok, it was just kind of a strange behaviour while working with the numeric values.

@myfunnyandy
Copy link
Contributor

Totally agree, that's why we want to implement the change ;)

@daniel-herrero daniel-herrero added the self-hosted The issue is happening on a self-hosted instance label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue self-hosted The issue is happening on a self-hosted instance
Projects
None yet
Development

No branches or pull requests

3 participants