Skip to content

Commit 814ca58

Browse files
committed
umpf: omit hash/version info on show without --identical
The topic-range and hashinfo information won't be used later on, unless --identical is given. It thus makes sense to ignore them in umpf show too, unless the user requests them with --identical. Signed-off-by: Ahmad Fatoum <[email protected]>
1 parent a3616f4 commit 814ca58

File tree

9 files changed

+30
-10
lines changed

9 files changed

+30
-10
lines changed

tests/meson.build

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ tests = [
2323
'umpf-format-patch',
2424
'umpf-format-patch-bb',
2525
'umpf-show',
26+
'umpf-show-identical',
2627
'umpf-versions'
2728
]
2829
foreach test_name : tests

tests/series-identical-v1.ref

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# umpf-base: base
2+
# umpf-name: name
3+
# umpf-version: name/20221209-1
4+
# umpf-topic: a
5+
# umpf-hashinfo: f46ed0419d2c31ed10f978cc461e0d1ae4b3b426
6+
# umpf-topic-range: d306da785d874c09b89264d3f71632bc14bfe51f..b2b9f854952b0be84ba2472f236783d09bfa6561
7+
# umpf-topic: b
8+
# umpf-hashinfo: 3755a03cf640725df1aeb13789cba87154a47b04
9+
# umpf-topic-range: b2b9f854952b0be84ba2472f236783d09bfa6561..e791a2bb22e021b8513809e1e1cbf692be74fd99
10+
# umpf-end

tests/series-v1.ref

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
# umpf-base: base
22
# umpf-name: name
3-
# umpf-version: name/20221209-1
43
# umpf-topic: a
5-
# umpf-hashinfo: f46ed0419d2c31ed10f978cc461e0d1ae4b3b426
6-
# umpf-topic-range: d306da785d874c09b89264d3f71632bc14bfe51f..b2b9f854952b0be84ba2472f236783d09bfa6561
74
# umpf-topic: b
8-
# umpf-hashinfo: 3755a03cf640725df1aeb13789cba87154a47b04
9-
# umpf-topic-range: b2b9f854952b0be84ba2472f236783d09bfa6561..e791a2bb22e021b8513809e1e1cbf692be74fd99
105
# umpf-end

tests/umpf-merge

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
umpf merge a
77
umpf merge b
88

9-
umpf show --base=base --name=name > series.merge
9+
umpf show --identical --base=base --name=name > series.merge
1010

1111
diff -u ${TEST_DIR}/series-merge.ref series.merge

tests/umpf-merge-build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@
66
git checkout umpf-merge
77
umpf build --remote=origin --base=base --name=name
88

9-
umpf show > series.build
9+
umpf show --identical > series.build
1010
diff -u ${TEST_DIR}/series-merge.ref series.build

tests/umpf-series-build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ git ls-tree umpf-build > ls-tree.ref
99
git ls-tree HEAD > ls-tree.build
1010
diff -u ls-tree.ref ls-tree.build
1111

12-
umpf show HEAD > series.build
12+
umpf show --identical HEAD > series.build
1313
diff -u ${TEST_DIR}/series-merge.ref series.build

tests/umpf-series-tag-continue-flags

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ sed -i '/^# umpf-base: base$/a # umpf-flags: extraversion=conflictfree' series.c
2020
umpf tag -f --version=2 series.conflict --remote=origin || test $? = 1
2121
git add a.txt
2222
echo | umpf continue
23-
umpf show 2>&1
23+
umpf show --identical 2>&1
2424

2525
diff -u ${TEST_DIR}/version-files/ref/Makefile.conflictfree Makefile
2626
git log --format=%B -n 1 | grep "^# umpf-" > series.tag

tests/umpf-show-identical

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
#!/bin/bash
2+
#
3+
# Test the output of "umpf show".
4+
#
5+
6+
umpf show --identical umpf-tag > series.show
7+
8+
diff -u ${TEST_DIR}/series-identical-v1.ref series.show

umpf

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1877,7 +1877,13 @@ do_abort() {
18771877
18781878
do_show() {
18791879
VERBOSE=true
1880-
prepare_persistent show "${@}"
1880+
prepare_persistent show "${@}" | (
1881+
if $IDENTICAL; then
1882+
cat
1883+
else
1884+
sed -r '/^# umpf-(version|topic-range|hashinfo|release): /d'
1885+
fi
1886+
)
18811887
cleanup
18821888
}
18831889

0 commit comments

Comments
 (0)