Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-555 Allow easy update of autonomous systems on RIPE IRR #556

Closed
wants to merge 1 commit into from

Conversation

jasjukaitis
Copy link

Closes: #555

Users can update peerings on RIPE IRR with a push of a button.

@gmazoyer gmazoyer self-assigned this Feb 22, 2022
@gmazoyer gmazoyer added this to In progress in Deployment/Interaction via automation Feb 22, 2022
@gmazoyer
Copy link
Member

gmazoyer commented Mar 6, 2022

Thanks for the PR and the impressive amount of work your done.

I feel that we could do this a little bit differently and in a more generic fashion, which implies even more work to be achieved.

The current implementation of this PR is very similar to what a web hook could do, not being a web hook though. I've been thinking about "export template" lately, in a way we could leverage the Jinja2 templating system we already have and export a rendered template to something (an HTTP endpoint, a Git repository, something else?).

What do you think about it? Are you up to work on it (with me)?

@jasjukaitis
Copy link
Author

Oh, I wasn't aware of web hooks. Indeed it makes sense to use Jinja2 here too.

The rationale here is, that the user has still the possibility to review changes, so not sure if it's good to update IRR right after saving like a web hook would do.

@jasjukaitis jasjukaitis force-pushed the feat/ripe-irr branch 4 times, most recently from 52d629b to 9a7969e Compare April 22, 2022 19:32
@gmazoyer
Copy link
Member

I'm closing this PR as a generic export template feature has been released in 1.7.0. It can generate a RIPE object given the right template but cannot export it to a URL yet. This can be the subject of another PR (if not implemented before).

@gmazoyer gmazoyer closed this Aug 21, 2022
Deployment/Interaction automation moved this from In progress to Done Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request Issue is an accepted feature request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Allow export template to be sent to a URL
2 participants