Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGP community type #479

Open
Paktosan opened this issue Aug 18, 2021 · 2 comments
Open

BGP community type #479

Paktosan opened this issue Aug 18, 2021 · 2 comments
Assignees
Labels
priority: medium status: accepted type: enhancement Issue is considered as an enhancement to the code, so it is not a regression nor a blocking issue

Comments

@Paktosan
Copy link
Contributor

Some router platforms have different configuration sections for standard, extended or large communities, so we have to differentiate between them when generating a configuration in Peering Manager.
While it is possible to use tags for this, it is not a very elegant solution.
As discussed on Slack, I would propose to automatically detect the community type and make it available as a property so it can be used in templating.

@gmazoyer gmazoyer self-assigned this Aug 18, 2021
@gmazoyer gmazoyer added priority: medium status: accepted type: enhancement Issue is considered as an enhancement to the code, so it is not a regression nor a blocking issue labels Aug 18, 2021
@gmazoyer
Copy link
Member

I've been thinking about this and maybe the best way to bring this feature is to add a field for it with a value for the user to select. Vendors are using different notations and it will come with pain if we have to parse these notations to determine the community type.

Second point if we were to add that field, we already have one called type to mention when the community is applied. Should we rename that field? I also started a discussion a few weeks back to propose deprecating it, but it looks like we'll keep it as optional.

@wtremmel
Copy link
Contributor

Hmm, IMHO the community type is implicit - you enter a community and because regular, extended and large communities are syntactically very different you see what type it is.

Alternatively, let the user select what they want, but then implement a strict syntax check that only valid communities of that type can be entered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium status: accepted type: enhancement Issue is considered as an enhancement to the code, so it is not a regression nor a blocking issue
Projects
None yet
Development

No branches or pull requests

3 participants