New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vcard): parse vcard module #1995
base: main
Are you sure you want to change the base?
Conversation
closes #1994 |
thanks |
Should this be working with multiple cards? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make ESList god happy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works on ios, android and web.
Remove all formatting changes |
Installing npm install git+https://github.com/CyrilLacroix/whatsapp-web.js.git get a TypeError: data.id.id.substring is not a function When is it going to be merge to master? |
Where we standing with this? |
When this pull merge it? It works flawlessly @PurpShell @tuyuribr @shirser121 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested its work
Didn´t work to me |
I tested the change and confirm that it fixes the problem. |
vcardGetNameFromParsed is no longer usable, I have switched to parsed.N[0].value.join(' ').trim() |
Can you share all the code changes need to be placed? |
1 similar comment
Can you share all the code changes need to be placed? |
src/util/Injected.js in line 270: |
thx but it still doesnt work at least for me. any other way to rectify the issue? |
how do I solve this, please explain what needs to be replaced. |
PR Details
Fix for vCard parsing.
Description
The module vcardFromContactModel doesn't contain parseVcard and vcardGetNameFromParsed functions anymore.
They can be found in the module WA_BIZ_NAME.
closes #1994 closes #2680
Motivation and Context
The vCard was not display, the content of the vCard was sent to Whatsapp chat.
How Has This Been Tested
Tested with a Bot, the vCard is now generated and displayed properly in Whatsapp.
Types of changes
Checklist