Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Arguments #112

Open
lukesg08 opened this issue Oct 4, 2023 · 4 comments
Open

System Arguments #112

lukesg08 opened this issue Oct 4, 2023 · 4 comments
Labels
laundry list This issue raises a number of bugs or enhancements

Comments

@lukesg08
Copy link
Collaborator

lukesg08 commented Oct 4, 2023

I think we have somewhere in the documentation that we do not handle system arguments. This should be added to our list of things to deal with.

@lukesg08 lukesg08 added the laundry list This issue raises a number of bugs or enhancements label Oct 4, 2023
@acbart
Copy link
Collaborator

acbart commented Feb 25, 2024

Would this be sys.args? So you'd want to be able to provide a sys.args value conveniently? Because I think you can use the existing infrastructure to achieve this, but it's not as convenient as it could be. You'd need to provide some information to TIFA, and also add the data to the sandbox. But it would be pretty easy to provide some easy convenience functions to make that happen. I think there's some work per environment to do too, to make sure the data gets passed in conveniently.

@lukesg08
Copy link
Collaborator Author

lukesg08 commented Feb 26, 2024

Yes, this would be sys.args. I'd expect this would actually be something in the run function from the sandbox for Pedal, but I didn't see an option for that in the teacher reference.

@acbart
Copy link
Collaborator

acbart commented Mar 20, 2024

Conversation at SIGCSE is that likely we should put this on run and make it easy for the instructors to specify. Also probably provide a set_sys_args similar to how we do that for set_input.

@acbart
Copy link
Collaborator

acbart commented Sep 20, 2024

Not sure where this left off, but I notice in the current version it seems like sys args leaks into the students' code execution. We should make sure that this is more tightly controlled!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
laundry list This issue raises a number of bugs or enhancements
Projects
None yet
Development

No branches or pull requests

2 participants