Skip to content

Gradle 8.5 & AGP 8.1.4 uprades #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

WhosNickDoglio
Copy link
Contributor

@WhosNickDoglio WhosNickDoglio commented Mar 2, 2025

Release notes: https://docs.gradle.org/8.5/release-notes.html

Upgrading to Gradle 8.5 comes with two major benefits:

  1. We can now use Version Catalog as they were marked stable in Gradle 8.3
  2. Greatly simplify publishing KMP aritfacts to Maven Central via https://github.com/vanniktech/gradle-maven-publish-plugin

I also ended up needing to upgrade to AGP 8.1.4 to get the project to build again. AGP 7.4.0 was using a Kotlin version older than what is being used in Gradle 8.5 that led to this super useful error message:

/Users/nicholasdoglio/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlinx/kotlinx-coroutines-core-jvm/1.8.0/ac1dc37a30a93150b704022f8d895ee1bd3a36b3/kotlinx-coroutines-core-jvm-1.8.0.jar!/META-INF/kotlinx-coroutines-core.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.9.0, expected version is 1.7.1.

As part of the AGP 8.1.4 upgrade I was also able to delete the AndroidManifest.xml file and just add a namespace entry in the build.gradle.kts file with the package name. More info here

Release notes: https://docs.gradle.org/8.5/release-notes.html

Upgrading to Gradle 8.5 comes with two major benefits:

1. We can now use Version Catalog as they were marked stable in Gradle 8.3
2. Greatly simplify publishing KMP aritfacts to Maven Central via https://github.com/vanniktech/gradle-maven-publish-plugin
@WhosNickDoglio WhosNickDoglio marked this pull request as ready for review March 2, 2025 15:47
@WhosNickDoglio WhosNickDoglio changed the title Gradle 8.5 upgrade Gradle 8.5 & AGP 8.1.4 uprades Mar 2, 2025
@crc-32
Copy link
Member

crc-32 commented Mar 5, 2025

@WhosNickDoglio could you update CI to use java compatible with new AGP version

@WhosNickDoglio
Copy link
Contributor Author

@crc-32 Updated 🫡

@crc-32 crc-32 merged commit ade8cc5 into pebble-dev:master Mar 5, 2025
1 check passed
@WhosNickDoglio WhosNickDoglio deleted the ndoglio/gradle-upgrade branch March 5, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants