Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(deprecate then?) remove the gzopen/gztell/gzseek shim #48

Open
mcdruid opened this issue Mar 15, 2024 · 1 comment
Open

(deprecate then?) remove the gzopen/gztell/gzseek shim #48

mcdruid opened this issue Mar 15, 2024 · 1 comment

Comments

@mcdruid
Copy link
Contributor

mcdruid commented Mar 15, 2024

Per #47 (comment) a shim was added for an old PHP 5 bug.

It causes a warning when validating package.xml and is likely no longer required in the vast majority of cases.

Anyone using an affected PHP version could provide the shim another way.

@ashnazg
Copy link
Member

ashnazg commented Mar 16, 2024

Looking over this shim history, I'd say keep it until such time as you decide to drop PHP 5.5 at least. The validate warning will just be a reminder ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants