fix: Inconsistent behavior between pdm remove and pdm update (#2886)

* fix: Inconsistent behavior between `pdm remove` and `pdm update` Fixes #2885 Signed-off-by: Frost Ming <[email protected]> * fix: add test Signed-off-by: Frost Ming <[email protected]>
pdm-project · May 16, 2024 · 98928b8 · 98928b8
1 parent e504768
commit 98928b8
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/news/2885.bugfix.md b/news/2885.bugfix.md
@@ -0,0 +1 @@
+Raise an error if the package given by `pdm update` does not exist in the select dependency group but in other groups.
diff --git a/src/pdm/cli/commands/update.py b/src/pdm/cli/commands/update.py
@@ -149,6 +149,14 @@ def do_update(
  f"[req]{name}[/] does not exist in [primary]{group}[/] "
  f"{'dev-' if selection.dev else ''}dependencies nor is a transitive dependency."
  )
+ look_in_other_group = next(
+ (g for g, deps in all_dependencies.items() if normalized_name in deps and g != group), None
+ )
+ if look_in_other_group is not None:
+ raise ProjectError(
+ f"[req]{name}[/] does not exist in [primary]{group}[/], but exists in [primary]{look_in_other_group}[/]."
+ " Please specify the correct group with `-G/--group`."
+ )
  tracked_names.add(normalized_name)
  else:
  matched_req.prerelease = prerelease

diff --git a/tests/cli/test_update.py b/tests/cli/test_update.py
@@ -184,13 +184,21 @@ def test_update_transitive(project, repository, pdm):
 
 
 @pytest.mark.usefixtures("working_set")
-def test_update_transitive_nonexistant_dependencies(project, repository, pdm):
+def test_update_transitive_nonexistant_dependencies(project, pdm):
  pdm(["add", "requests", "--no-sync"], obj=project, strict=True)
- result = pdm(["update", "numpy"])
+ result = pdm(["update", "numpy"], obj=project)
  assert "ProjectError" in result.stderr
  assert "numpy does not exist in" in result.stderr
 
 
+@pytest.mark.usefixtures("working_set")
+def test_update_package_wrong_group(project, pdm):
+ pdm(["add", "-d", "requests"], obj=project, strict=True)
+ result = pdm(["update", "requests"], obj=project)
+ assert "ProjectError" in result.stderr
+ assert "requests does not exist in default, but exists in dev" in result.stderr
+
+
 @pytest.mark.usefixtures("working_set")
 def test_update_transitive_non_transitive_dependencies(project, repository, pdm):
  pdm(["add", "requests", "pytz", "--no-sync"], obj=project, strict=True)