Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into including US territories in map #20

Open
pdil opened this issue Jul 16, 2019 · 5 comments
Open

Look into including US territories in map #20

pdil opened this issue Jul 16, 2019 · 5 comments
Assignees
Labels
needs refinement Features, enhancements, or bugs that require more refinement before they are ready to be worked on new feature A new feature that adds functionality to the package
Milestone

Comments

@pdil
Copy link
Owner

pdil commented Jul 16, 2019

US territories are frequently excluded from US maps. In the spirit of this package, which is to include often forgotten Alaska & Hawaii, it may be a good idea to allow the option to present the inhabited US territories on the map as well.

The territories being considered are:

  • American Samoa
  • Guam
  • Northern Mariana Islands
  • Puerto Rico
  • US Virgin Islands

These territories all have FIPS codes and official abbreviations so incorporating them into the data set should be seamless.

The difficult part will be moving the coordinates of these places so that they appear on the map in a suitable and aesthetically adequate part of the US map.

@pdil pdil added the enhancement A suggestion or feature that improves existing functionality label Jul 16, 2019
@pdil pdil self-assigned this Jul 16, 2019
@pdil pdil changed the title Look into including American Samoa, Guam, Northern Mariana Islands, Puerto Rico, US Virigin Islands Look into including US territories in map Jul 16, 2019
@dcaud
Copy link

dcaud commented Apr 21, 2020

I'd really appreciate this! I believe Puerto Rico has > 3,000,000 residents, whereas the other territories have less than 200,000. All would be great! But maybe just start with PR and add it inside the Gulf of Mexico?

@dcaud
Copy link

dcaud commented Apr 22, 2020

I've looked at your code a bit and might try to revise it to include PR.

The basic requirements seem to be:

  1. Revise Transform.R:
    A. duplicate the Hawaii (or Alaska) functions with updated coord values for PR.
    B. update # combine all point to merge in the new PR.

  2. Add "PR,72,PUERTO RICO" to states-fips.R

  3. Add outline of PR in create-map-df.R

  4. Run make-all.R to update data for PR outline

Is that the basics? If so, I might give it a try later today.

@pdil
Copy link
Owner Author

pdil commented Apr 22, 2020

@dcaud That's correct, I think you got it. Feel free to open a PR and we can work through it to make sure everything is included. Thanks!

@dcaud
Copy link

dcaud commented Apr 22, 2020

I opened a PR and made some changes. I guess we can continue the conversation over there!

@pdil pdil added needs refinement Features, enhancements, or bugs that require more refinement before they are ready to be worked on new feature A new feature that adds functionality to the package and removed enhancement A suggestion or feature that improves existing functionality labels Nov 6, 2020
@pdil pdil mentioned this issue Jun 6, 2022
@pdil pdil pinned this issue Dec 11, 2023
@pdil pdil added this to the v0.7.0 milestone Dec 11, 2023
@pdil pdil removed this from the v0.7.0 milestone Jan 12, 2024
@pdil pdil unpinned this issue Jan 12, 2024
@pdil pdil added this to the v1.0.0 milestone Jan 12, 2024
@pdil pdil pinned this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs refinement Features, enhancements, or bugs that require more refinement before they are ready to be worked on new feature A new feature that adds functionality to the package
Projects
None yet
Development

No branches or pull requests

2 participants