Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move questionnaire (psdm_qs_cli) backend out of happi #195

Open
klauer opened this issue Jan 6, 2021 · 1 comment
Open

Move questionnaire (psdm_qs_cli) backend out of happi #195

klauer opened this issue Jan 6, 2021 · 1 comment
Labels
backend Database backends questionnaire Questionnaire backend

Comments

@klauer
Copy link
Contributor

klauer commented Jan 6, 2021

Expected Behavior

LCLS-specific questionnaire backend, with its dependency psdm_qs_cli, should not be part of happi.

Current Behavior

LCLS-specific psdm_qs_cli is an included backend in happi: https://github.com/pcdshub/happi/blob/master/happi/backends/qs_db.py

Possible Solution

We have some preliminary ways to add backends externally from happi.
It's not as sophisticated as it should be for general use: https://github.com/pcdshub/happi/blob/master/happi/backends/__init__.py

As we use entrypoints for container classes and already have it as a dependency, it may make sense to go that route.

@klauer klauer added backend Database backends questionnaire Questionnaire backend labels Jan 19, 2021
@hhslepicka
Copy link
Contributor

I just noticed that this one is the same as #130 but much better described. Just looping it in so when this gets closed the other one can go together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Database backends questionnaire Questionnaire backend
Projects
None yet
Development

No branches or pull requests

2 participants