Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

any command causes to run git --version and git lfs --version multiple times #326

Open
Merith-TK opened this issue Apr 20, 2024 · 2 comments
Open

any command causes to run git --version and git lfs --version multiple times #326

Merith-TK opened this issue Apr 20, 2024 · 2 comments

Comments

@Merith-TK
Copy link
Contributor

Merith-TK commented Apr 20, 2024 •
edited
Loading

I ran backup gc after making a backup

image
@Merith-TK
Copy link
Contributor Author

fresh logs from local dev

[05:46:56] [Server thread/INFO] (Minecraft) <Mekrath> running gc
[05:47:01] [Server thread/INFO] (fastback) [DEBUG] executing net.pcal.fastback.commands.Commands$$Lambda$8014/0x000002ac82fd5a68@352b0d1b
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] Executing git --version
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] PATH: null
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] USER: null
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] HOME: null
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] [STDOUT] git version 2.42.0.windows.2
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] Executing git lfs --version
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] PATH: null
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] USER: null
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] HOME: null
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] [STDOUT] git-lfs/3.4.0 (GitHub; windows amd64; go 1.20.6; git d06d6e9e)
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] Executing git --version
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] PATH: null
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] USER: null
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] HOME: null
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] [STDOUT] git version 2.42.0.windows.2
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] Executing git lfs --version
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] PATH: null
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] USER: null
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] HOME: null
[05:47:01] [pool-6-thread-1/INFO] (fastback) [DEBUG] [STDOUT] git-lfs/3.4.0 (GitHub; windows amd64; go 1.20.6; git d06d6e9e)

@Merith-TK
Copy link
Contributor Author

Merith-TK commented Apr 20, 2024 •
edited
Loading

found where it is
its the isNativeOk() checks, they call the functions multiple times

perhaps caching the results of the version strings could help with this

Merith-TK added a commit to Merith-TK/fastback that referenced this issue Apr 20, 2024
@Merith-TK
fix pcal43#326
b554d0f 
cache initial git --version check from onInitialize, reload value with `backup info`
@Merith-TK Merith-TK mentioned this issue May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Merith-TK