chore(tests): use vitest #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregjopa
commented
Jun 1, 2023
| @@ -319,17 +319,4 @@ describe("loadCustomScript()", () => { | |||
| ); | |||
| expect(PromisePonyfill).toHaveBeenCalledTimes(1); | |||
| }); | |||
|
|
|||
| test("should throw an error when the Promise implementation is undefined", () => { | |||
There was a problem hiding this comment.
Admittedly, this is a bad test that had to delete the global Promise object. I ended up removing this test since I was unable to get it working with vitest.
I'm thinking we can actually get rid of this custom error message and just let the browser throw a standard error message in IE11 when window.Promise is undefined. https://github.com/paypal/paypal-js/blob/main/src/load-script.ts#L117-L119
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 2 2
Lines 128 299 +171
Branches 36 56 +20
==========================================
+ Hits 128 299 +171
☔ View full report in Codecov by Sentry. |
wsbrunson
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces Jest with vitest.
I stuck with jsdom since happy-dom executes
<script>tags by default and was difficult to switch out. There are also some differences in type definitions for the DOM. Sticking with jsdom made this upgrade pretty easy.