add style.label to aria-label #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2169 +/- ##
==========================================
+ Coverage 51.49% 51.58% +0.08%
==========================================
Files 101 101
Lines 1967 1983 +16
Branches 572 582 +10
==========================================
+ Hits 1013 1023 +10
- Misses 856 862 +6
Partials 98 98
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
wsbrunson
approved these changes
Jun 7, 2023
Comment on lines
+46
to
+61
| labelText: ({ content, label, period }) => { | ||
| let text = `${FUNDING_BRAND_LABEL.PAYPAL}`; | ||
| if (content && label === BUTTON_LABEL.INSTALLMENT) { | ||
| if (period) { | ||
| text = content["label.installment.withPeriod"].replace( | ||
| "{period}", | ||
| String(period) | ||
| ); | ||
| } else { | ||
| text = content["label.installment.withoutPeriod"]; | ||
| } | ||
| } else if (content && label) { | ||
| text = content[`label.${label}`]; | ||
| } | ||
| return text; | ||
| }, |
There was a problem hiding this comment.
we should consider unit testing this
There was a problem hiding this comment.
good call - let me see if that could be a quick win!
wsbrunson
approved these changes
Jun 7, 2023
jshawl
added a commit
to jshawl/paypal-checkout-components
that referenced
this pull request
Jun 15, 2023
This PR is a follow up to paypal#2169 (29a18ec) that introduced an issue related to the correct content not being available.
Merged
jshawl
added a commit
that referenced
this pull request
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds localized text to the
aria-labelfor the PayPal button whenstyle.labelis set.Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Improve accessibility with more accurate
aria-labelvalues. Previously, the name of the funding source was used, which ended up being "PayPal" even in cases where a label was set.Screenshots (if applicable)
❤️ Thank you!