Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod should use fully qualified module path #113

Open
justinfx opened this issue May 21, 2023 · 5 comments
Open

go.mod should use fully qualified module path #113

justinfx opened this issue May 21, 2023 · 5 comments

Comments

@justinfx
Copy link

The go.mod file says module juno, where it should be updated to module github.com/paypal/junodb to be "go get" compatible and properly document the client on pkg.go.dev

@Ahmadkashif
Copy link
Contributor

Hi @justinfx , I would like to work on this.

@Ahmadkashif
Copy link
Contributor

Hi @justinfx, take a look at what I tried, it might be a little off as I only had a 1-liner issue description. Let me know if it is what you wanted.

@justinfx
Copy link
Author

Hi @Ahmadkashif. Sorry if my description wasn't clear. I had assumed the issue was pretty straightforward via the common Go module documentation. But I hadn't considered you would have also needed to update all of the import paths as well. So definitely not a one line change. Good thing IDE refactoring usually handles it all in one step, and the compiler checks it as well.
Changes look good to me!

@justinfx
Copy link
Author

@Ahmadkashif
Copy link
Contributor

I'm happy to help @justinfx .

Let's get the ball rolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants