Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CheckStyle] Fix CheckStyle Warnings, Ensure we have 0 Warnings #24

Open
Dee-Pac opened this issue Apr 6, 2018 · 2 comments
Open

[CheckStyle] Fix CheckStyle Warnings, Ensure we have 0 Warnings #24

Dee-Pac opened this issue Apr 6, 2018 · 2 comments
Labels
good first issue Easy for newcomers to pickup and contribute. Gimel internals are not required to be known.

Comments

@Dee-Pac
Copy link
Contributor

Dee-Pac commented Apr 6, 2018 •
edited by r39132

Currently CheckStyle is set to Warning Level for several modules. This is because we have to do a lot of code cleanup to adhere to rules specified in checkstyle specification.

Without adding/changing any logic : only address the style sheet errors.

A plugin can be used to auto-fix the checkstyle violations. But this requires post-fix validation to ensure there is no inadvertent logic changes performed by any plugin that is used.

Other way is to fix manually each module.

Ensure the current code base adheres to the checkstyle by running the autofixer on the entire code base.
@Dee-Pac Dee-Pac added the good first issue Easy for newcomers to pickup and contribute. Gimel internals are not required to be known. label Apr 6, 2018
@Rishi55
Copy link

Rishi55 commented Jan 21, 2022

I would like to take this up!!

@Dee-Pac
Copy link
Contributor Author

Dee-Pac commented Jan 21, 2022

@Rishi55 Yes, This is still an open issue. Please let us know if you would like to work on this. We can assign the issue accordingly. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Easy for newcomers to pickup and contribute. Gimel internals are not required to be known.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rishi55 @Dee-Pac