-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'With icon' variant of accordion #1264
Comments
Thanks for this Mary. I see this as a variant but I'll look more closely at your Sketch file. Are the newly added icons just a visual feature or are they clickable? Saw the blue and brain went to a link. |
@andrew-ronaldson They aren't clickable, but rather a stylistic decision to add some visual interest since this pattern will be used on ConsoleDot to show key features and use cases of a service (so we want to add some visual weight there) |
@mcoker any thoughts on this addition to the component? Seems doable as an optional feature. |
I can't see the sketch file, but the screenshot looks like an expandable data-list and table, minus the blue border on the left. That border used to be on tables/data-lists, but it was removed. Adding an icon would be really straight forward, it could be as simple as a prop on an Adding additional actions is a bit of a bigger ask since in the accordion, all of the styling on the toggle is on a |
Correct me if I'm wrong @maryshak1996 but I think this seems like a prop that adds a decorator which is separate from any actions so it would just follow the accordion button. Maybe this would need a tooltip to identify the icon as a specific service? |
hey yes that's correct @andrew-ronaldson :) it's just a decorator icon! I don't even think it would need a tooltip since the text next to it would provide that context |
@andrew-ronaldson @maryshak1996 ah - just an icon like this? https://codesandbox.io/s/naughty-nova-d8tgl7?file=/index.html |
@mcoker yup exactly! If it was possible to choose which side (left or right) the expandable icon could be located on the accordion toggle that would be great, but definitely not a hill I'm going to die on! When the accordion is at full-width, it feels like the expandable toggle is pretty far away from the title it's expanding is all. |
@maryshak1996 cool! @andrew-ronaldson both of those enhancements should be pretty straight forward. |
@lboehling @blfetche do we want to get this in the penta work? |
I'm not sure if this isn't a variant of the 'accordion' or if it's more a variant of the 'expandable' component, but I wanted to contribute this concept that we are using in our console landing page templates (having it be a PF component would make it even easier for folks to adhere to our landing page guidance).
Several examples of usage for this component can be seen in this Sketch here. Here is the component itself, consisiting of ...
The text was updated successfully, but these errors were encountered: