Merge pull request #27 from patch-technology/lovisa/fix-sdg

Fix thrown error when calling Patch::Sdg

Author: biglovisa

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.5.1] - 2021-03-02
+
+### Fixed
+
+- Fixed a `NameError` that was thrown when `Patch::Sdg` was called. Specs have been added to ensure this does not happen again.
+
 ## [1.5.0] - 2021-03-01
 
 ### Changed

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    patch_ruby (1.4.0)
+    patch_ruby (1.5.1)
       json (~> 2.1, >= 2.1.0)
       typhoeus (~> 1.0, >= 1.0.1)
 

lib/patch_ruby.rb

@@ -36,6 +36,7 @@
 require 'patch_ruby/models/project'
 require 'patch_ruby/models/project_list_response'
 require 'patch_ruby/models/project_response'
+require 'patch_ruby/models/sdg'
 require 'patch_ruby/models/standard'
 
 # APIs

lib/patch_ruby/version.rb

@@ -11,5 +11,5 @@
 =end
 
 module Patch
-  VERSION = '1.5.0'
+  VERSION = '1.5.1'
 end

spec/patch_ruby_spec.rb

@@ -0,0 +1,18 @@
+describe Patch do
+  context 'Models' do
+    it 'defines all models' do
+      constants.each do |constant|
+        expect { Patch.const_get(constant) }.not_to raise_error
+      end
+    end
+  end
+
+  def constants
+    # Given a file path return the constant of that path, for example:
+    # 'lib/patch_ruby/models/project_response.rb' -> ProjectResponse
+    Dir.glob("lib/patch_ruby/models/*.rb").map do |file|
+      parsed_filename = file.split('/').last.split('.').first
+      constant = parsed_filename.split('_').map(&:capitalize).join('')
+    end
+  end
+end