Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken link on readthedocs page to Examples #882

Open
AnneDeGraaf opened this issue Feb 7, 2025 · 4 comments
Open

broken link on readthedocs page to Examples #882

AnneDeGraaf opened this issue Feb 7, 2025 · 4 comments
Assignees
Labels
bug Indicates an unintended behavior or coding error documentation Indicates a need for improvements or additions to documentation good-first-issue

Comments

@AnneDeGraaf
Copy link

Describe the bug
On https://pastas.readthedocs.io/latest/userguide/post_processing.html the link to the "Example Notebooks" page is broken. I get a 404.

To Reproduce
Go to https://pastas.readthedocs.io/latest/userguide/post_processing.html and click the "Example Notebooks" link.

Expected behavior
Directing the user to the Examples page https://pastas.readthedocs.io/latest/examples/index.html

Python package version

  • "latest", "stable", maybe more but I didn't check all versions.
@AnneDeGraaf AnneDeGraaf added the bug Indicates an unintended behavior or coding error label Feb 7, 2025
@dbrakenhoff dbrakenhoff added documentation Indicates a need for improvements or additions to documentation good-first-issue labels Feb 7, 2025
@protokoul
Copy link

Hi. I see that "latest", "stable", "dev", and all the versions from v1.0.0 onwards are affected by this issue, whereas for versions v0.15.0 to v0.23.1, this link https://pastas.readthedocs.io/v1.2.0/userguide/post_processing.html itself returns a 404. Please help me with the following queries:

  1. In the contributing guide, it says that all the PRs should be submitted to the dev branch. As I understand, the link needs to be updated for all the versions that are affected, so do I need to submit PRs for the other affected branches as well?
  2. For versions v0.15.0 to v0.23.1, should https://pastas.readthedocs.io/v1.2.0/userguide/post_processing.html be removed from the docs?

@raoulcollenteur
Copy link
Member

Thanks @protokoul. We just want to want to update the dev versions and leave the others as is. @AnneDeGraaf is already on this to make a fix :) Thanks for offering help though.

Cheers,
Raoul

@raoulcollenteur
Copy link
Member

Hi @AnneDeGraaf,

Just to let you know, I am updating these notebooks and will directly address this issue as well. So no need to work on this :)

Cheers,
Raoul

@AnneDeGraaf
Copy link
Author

AnneDeGraaf commented Feb 26, 2025 via email

@martinvonk martinvonk changed the title [BUG] broken link on readthedocs page to Examples broken link on readthedocs page to Examples Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unintended behavior or coding error documentation Indicates a need for improvements or additions to documentation good-first-issue
Projects
None yet
Development

No branches or pull requests

4 participants