Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PSR with repeated parameters incorrect #29

Open
atiyo opened this issue Sep 12, 2024 · 0 comments · May be fixed by #31
Open

[BUG] PSR with repeated parameters incorrect #29

atiyo opened this issue Sep 12, 2024 · 0 comments · May be fixed by #31
Assignees
Labels
bug Something isn't working

Comments

@atiyo
Copy link
Collaborator

atiyo commented Sep 12, 2024

Same problem as pasqal-io/pyqtorch#217, i.e. if a single parameter is used mutiple times in a circuit, the resulting PSR gradient is incorrect.

However, the fix in pasqal-io/pyqtorch#219 can't be straightfowardly applied to horqrux.

@atiyo atiyo added the bug Something isn't working label Sep 12, 2024
@atiyo atiyo self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant