Skip to content

Commit 7b5aac1

Browse files
RezaMohammadi99vmw
authored andcommitted
Fixed Project Report Remarks
This commit keeps the project remark connected to the newly selected items in a project report.
1 parent fad4de7 commit 7b5aac1

File tree

6 files changed

+30
-12
lines changed

6 files changed

+30
-12
lines changed

Profile

Whitespace-only changes.

src/PartKeepr/FrontendBundle/Resources/public/js/Components/Project/MetaPartSubgrid.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ Ext.define('PartKeepr.Components.Project.MetaPartSubgrid', {
8585
onApplyMetaPartsClick: function (button)
8686
{
8787
var parentRecord = button.up("grid").parentRecord;
88+
8889
this.convertMetaPartsToParts(parentRecord);
8990
},
9091
/**
@@ -97,7 +98,7 @@ Ext.define('PartKeepr.Components.Project.MetaPartSubgrid', {
9798
{
9899
var missing;
99100

100-
var i, projectReportItem, subPart, projectPart;
101+
var i, projectReportItem, subPart;
101102

102103
for (i = 0; i < record.subParts().getCount(); i++)
103104
{
@@ -112,15 +113,17 @@ Ext.define('PartKeepr.Components.Project.MetaPartSubgrid', {
112113
} else {
113114
missing = Math.abs(missing);
114115
}
115-
116+
117+
if(subPart.get("comment").indexOf("DO NOT CHANGE") == -1)
118+
subPart.set("comment", subPart.get("comment") + "\nDO NOT CHANGE:" + record.data.report + record._part.data.name);
119+
else if(subPart.get("comment").indexOf(record.data.report) != -1)
120+
subPart.set("comment", subPart.get("comment") + record._part.data.name);
121+
else
122+
subPart.set("comment", subPart.get("comment").slice(0,subPart.get("comment").indexOf("DO NOT CHANGE")+14) + record.data.report + record._part.data.name);
116123
projectReportItem = Ext.create("PartKeepr.ProjectBundle.Entity.ReportPart");
117124
projectReportItem.setPart(subPart);
118125
projectReportItem.set("quantity", subPart.get("stockToUse"));
119126
projectReportItem.setReport(this.up("#projectReportResult").projectReport);
120-
121-
projectPart = Ext.create("PartKeepr.ProjectBundle.Entity.ProjectPart");
122-
projectPart.setPart(subPart);
123-
projectPart.set("remarks", "remark");
124127
record.store.add(projectReportItem);
125128
}
126129
}

src/PartKeepr/FrontendBundle/Resources/public/js/Components/Project/ProjectReportResultGrid.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ Ext.define("PartKeepr.Components.Project.ProjectReportResultGrid", {
355355
amount: item.get("quantity"),
356356
comment: item.getReport().reportProjects().getFieldValues("project.name").join(", "),
357357
lotNumber: item.projectParts().getFieldValues("lotNumber").join(", "),
358-
projects: [] // item.getReport().reportProjects()
358+
projects: []
359359
});
360360
}
361361

src/PartKeepr/FrontendBundle/Resources/public/js/Components/Project/Renderers/RemarksRenderer.js

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,26 +9,40 @@ Ext.define("PartKeepr.Components.ProjectReport.Renderers.RemarksRenderer", {
99
getProjectParts: function (rec) {
1010

1111
var report = rec.getReport(),
12-
i, j, project, projectPart, projectPartQuantities = [];
12+
i, j, k, project, projectPart, projectPartQuantities = [];
1313

1414
for (i = 0; i < report.reportProjects().getCount(); i++)
1515
{
1616
project = report.reportProjects().getAt(i).getProject();
17-
17+
1818
for (j = 0; j < project.parts().getCount(); j++)
1919
{
2020
projectPart = project.parts().getAt(j);
21-
21+
22+
2223
if (projectPart.getPart().getId() === rec.getPart().getId())
2324
{
2425
if (projectPart.get("remarks") !== "" && projectPart.get("remarks") !== null)
2526
{
2627
projectPartQuantities.push(project.get("name") + ": " + projectPart.get("remarks"));
2728
}
2829
}
30+
else
31+
{
32+
33+
if (rec.getPart().data.comment.includes(projectPart.getPart().data.name))
34+
{
35+
if (projectPart.get("remarks") !== "" && projectPart.get("remarks") !== null)
36+
{
37+
projectPartQuantities.push(project.get("name") + ": " + projectPart.get("remarks"));
38+
}
39+
}
40+
41+
}
42+
2943
}
3044
}
31-
45+
3246
return projectPartQuantities.join("&#013;&#010;")
3347
},
3448

src/PartKeepr/FrontendBundle/Resources/public/js/PartKeepr.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ Ext.application({
233233
}
234234

235235
if (data.inactiveCronjobCount > 0) {
236-
alert(i18n("The following cronjobs aren't running:") + "\n\n" + data.inactiveCronjobs.join("\n"));
236+
//alert(i18n("The following cronjobs aren't running:") + "\n\n" + data.inactiveCronjobs.join("\n"));
237237
}
238238
},
239239
/*

src/PartKeepr/PartBundle/Entity/Part.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
*/
2828
class Part extends BaseEntity
2929
{
30+
private $origin;
3031
/**
3132
* The category of the part.
3233
*

0 commit comments

Comments
 (0)