considering splitting module or/plus library out of DemoAndroidLNjScheme

[0-8-15]

The code build a .jar using make and then needs to install that.

How would I do that the intended way?

[mgorges]

I highly doubt anyone on our team has ever even compiled this app. As in #273 (comment), I only merged it as it didn't break anything.

Doesn't targets/android/build-binary#L181 transfer files into the Android build? Or am I missing the question?

[0-8-15]

Am Mon, 28 Sep 2020 13:07:54 -0700 schrieb Matthias Görges <[email protected]>:

Doesn't [targets/android/build-binary#L181](https://github.com/part-cw/lambdanative/blob/01d94cb2eaf1114f2757cee36f1c185cce824814/targets/android/build-binary#L181) transfer files into the Android build? Or am I missing the question?

If I understand the code correct, transfers files from the `android_jars` directory in the **app**. What I'd need would be to copy them from the `android_jars` subdirectory of library/module. The problem I'm facing: 1. In order to include/not include it into an app properly I only know of creating a module and mention it in the `MODULES` file of the app. Hence I'd extend the source line you're referring to to look for `android_jars` in the modules list too. I'm unsure how to get that right - hence me asking for a hint. 2. Neither am I sure that pulling the jar from a module is actually the best choice. Maybe was better a library. What would you recommend? 3. In order to build the jar there is a java/jar invocation required. Currently this us done using `make` in an extra step, which is incompatible with a module build. Question: is there a paved way already? I don't want to reinvent the wheel.

[mgorges]

Modules can include more modules and libraries already, and plugins also can contain libraries - see https://github.com/part-cw/lambdanative/blob/e622c127599a13b8fb6428d34f8351f6e35cd4cd/make.sh#L922 so this principle should be applicable to other things too? However, I also know that some android things from modules are not included, so we haven't generalized the approach. Will need to give this some more thought in the coming days.

I think there is at least one library which uses jars: libraries/usb-serial-for-android/make.sh which fakes the .a file to satisfy the build process and silently includes the jar file too; the same is true for LNhealth: /libraries/sharevitalsigns/build.sh.in, which also allows for substitutions in the pre-processor.

Will also need to think more about the extra make for the jar - a library would solve this step - see either of those two examples above, but it is not a particularly clean/beautiful approach either.

[0-8-15]

Am Wed, 30 Sep 2020 00:57:49 -0700 schrieb Matthias Görges <[email protected]>:

Will also need to think more about the extra make for the jar - a library would solve this step - see either of those two examples above, but it is not a particularly clean/beautiful approach either.

For the extra `make` I already have an idea in mind I want to try out before going into details. Q: Which variable tells me in `scm.sh` how to call java/javac/jar?

[mgorges]

Q: Which variable tells me in scm.sh how to call java/javac/jar?

As we don't do this anywhere there isn't one. In fact, we call all the java-related tools like ant or jarsigner directly using the system-wide installed option, without the opportunity to override them? E.g. targets/android/build-binary#L336