fix

Author: mtrezza

spec/schemas.spec.js

@@ -3842,6 +3842,8 @@ describe('schemas', () => {
     });
 
     it_id('cbd5d897-b938-43a4-8f5a-5d02dd2be9be')(it_exclude_dbs(['postgres']))('cannot update to duplicate value on unique index', done => {
+      const logger = require('../lib/logger').default;
+      const loggerErrorSpy = spyOn(logger, 'error').and.callThrough();
       const index = {
         code: 1,
       };
@@ -3868,7 +3870,12 @@ describe('schemas', () => {
         .then(done.fail)
         .catch(error => {
           expect(error.code).toEqual(Parse.Error.DUPLICATE_VALUE);
-          expect(error.message).toEqual('A duplicate value for a field with unique values was provided. Duplicate index: code_1 on collection test_UniqueIndexClass in db parseServerMongoAdapterTestDatabase')
+          // Client should only see generic message (no schema info exposed)
+          expect(error.message).toEqual('A duplicate value for a field with unique values was provided');
+          // Server logs should contain full MongoDB error message with detailed information
+          expect(loggerErrorSpy).toHaveBeenCalledWith('Duplicate key error:', jasmine.stringContaining('E11000 duplicate key error'));
+          expect(loggerErrorSpy).toHaveBeenCalledWith('Duplicate key error:', jasmine.stringContaining('test_UniqueIndexClass'));
+          expect(loggerErrorSpy).toHaveBeenCalledWith('Duplicate key error:', jasmine.stringContaining('code_1'));
           done();
         });
     });

src/Adapters/Storage/Mongo/MongoStorageAdapter.js

@@ -27,29 +27,6 @@ const ReadPreference = mongodb.ReadPreference;
 
 const MongoSchemaCollectionName = '_SCHEMA';
 
-
-// If we get a unique index error from mongo, try to parse it. If successful, return it.
-const mongoUniqueIndexErrorFormatter = (message) => {
-  /**
-   * Sample error message that we are getting from mongo
-   * 'Plan executor error during findAndModify :: caused by :: E11000 duplicate key error collection: parseServerMongoAdapterTestDatabase.test_UniqueIndexClass index: code_1 dup key: { code: 2 }'
-   */
-  const regex = /collection:\s*([\w-]+)\.([\w-]+)\s+index:\s*([\w-]+)/;
-
-  const match = message.match(regex);
-
-  if (match) {
-    const dbName = match[1];
-    const collectionName = match[2];
-    const indexName = match[3];
-    // Adding extra starting space to make it more readable.
-    return ` Duplicate index: ${indexName} on collection ${collectionName} in db ${dbName}`;
-  }
-
-  // Return nothing
-  return '';
-}
-
 const storageAdapterAllCollections = mongoAdapter => {
   return mongoAdapter
     .connect()
@@ -542,10 +519,10 @@ export class MongoStorageAdapter implements StorageAdapter {
       .then(() => ({ ops: [mongoObject] }))
       .catch(error => {
         if (error.code === 11000) {
-          // Duplicate value
+          logger.error('Duplicate key error:', error.message);
           const err = new Parse.Error(
             Parse.Error.DUPLICATE_VALUE,
-            `A duplicate value for a field with unique values was provided.${mongoUniqueIndexErrorFormatter(error.message)}`
+            'A duplicate value for a field with unique values was provided'
           );
           err.underlyingError = error;
           if (error.message) {
@@ -628,9 +605,10 @@ export class MongoStorageAdapter implements StorageAdapter {
       .then(result => mongoObjectToParseObject(className, result, schema))
       .catch(error => {
         if (error.code === 11000) {
+          logger.error('Duplicate key error:', error.message);
           throw new Parse.Error(
             Parse.Error.DUPLICATE_VALUE,
-            `A duplicate value for a field with unique values was provided.${mongoUniqueIndexErrorFormatter(error.message)}`
+            'A duplicate value for a field with unique values was provided'
           );
         }
         throw error;