Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FCM http2 API #251

Closed
3 tasks done
mtrezza opened this issue May 25, 2024 · 7 comments · Fixed by #274
Closed
3 tasks done

Add support for FCM http2 API #251

mtrezza opened this issue May 25, 2024 · 7 comments · Fixed by #274

Comments

@mtrezza
Copy link
Member

mtrezza commented May 25, 2024

New Feature / Enhancement Checklist

Current Limitation

#219 added support for the FCM HTTP v1 API, which supports HTTP/2 connectivity.

Feature / Enhancement Description

Add support for sending push notifications via HTTP/2 connectivity when using FCM.

3rd Party References

Copy link

parse-github-assistant bot commented May 25, 2024

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza
Copy link
Member Author

mtrezza commented May 25, 2024

@jimnor0xF you wrote #219 (comment); could you please elaborate a bit what's to do here, if anything? cc @mman

@jimnor0xF
Copy link
Contributor

jimnor0xF commented May 25, 2024

@mtrezza
Unfortunately, firebase-admin-node in its current state does not use/support HTTP/2 at the moment.
So we are dependent on the maintainers for that package to add support for that first.

There is a PR up: firebase/firebase-admin-node#2550, so hopefully it is merged soon.
It probably will, since this is a pretty critical oversight on their part considering that the old API is supposed to be removed next month.

@mtrezza
Copy link
Member Author

mtrezza commented Jul 24, 2024

It seems the required PR has been merged today: firebase/firebase-admin-node#2550

Could we already start to prepare a PR that works with that change?

@jimnor0xF
Copy link
Contributor

jimnor0xF commented Jul 26, 2024

@mtrezza
Should be to just bump the version of the package to v12.3.0 from what I understand. Defaults to http2.

@mtrezza
Copy link
Member Author

mtrezza commented Jul 26, 2024

From firebase/firebase-admin-node#2488 (comment):

This can be enabled by using the enableLegacyTransport() method. This method is already marked as deprecated and will be removed once the HTTP/2 transport is considered fully stable.

Then maybe we should expose this method as well? Or will there be a way for developers access it?

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants