-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subsystem-bench: Remove benchmark_name
from BenchmarkUsage
#3601
Labels
C1-mentor
A task where a mentor is available. Please indicate in the issue who the mentor could be.
C2-good-first-issue
A task for a first time contributor to become familiar with the Polkadot-SDK.
R0-silent
Changes should not be mentioned in any release notes
T12-benchmarks
This PR/Issue is related to benchmarking and weights.
Comments
AndreiEres
added
R0-silent
Changes should not be mentioned in any release notes
C1-mentor
A task where a mentor is available. Please indicate in the issue who the mentor could be.
T12-benchmarks
This PR/Issue is related to benchmarking and weights.
C2-good-first-issue
A task for a first time contributor to become familiar with the Polkadot-SDK.
labels
Mar 6, 2024
Hi @AndreiEres, I'd like to work on this issue. Can you assign to me? Thanks. |
AndreiEres
changed the title
subsystem-bench: Deprecate
subsystem-bench: Remove Mar 7, 2024
benchmark_name
in BenchmarkUsage
benchmark_name
from BenchmarkUsage
@olaitanade Sure, looking forward to your PR! |
github-merge-queue bot
pushed a commit
that referenced
this issue
May 28, 2024
Fixes #3601 Since we print benchmark results manually, we don't need to save benchmark_name anywhere, better just put the name inside `println!`.
hitchhooker
pushed a commit
to ibp-network/polkadot-sdk
that referenced
this issue
Jun 5, 2024
Fixes paritytech#3601 Since we print benchmark results manually, we don't need to save benchmark_name anywhere, better just put the name inside `println!`.
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this issue
Aug 2, 2024
Fixes paritytech#3601 Since we print benchmark results manually, we don't need to save benchmark_name anywhere, better just put the name inside `println!`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C1-mentor
A task where a mentor is available. Please indicate in the issue who the mentor could be.
C2-good-first-issue
A task for a first time contributor to become familiar with the Polkadot-SDK.
R0-silent
Changes should not be mentioned in any release notes
T12-benchmarks
This PR/Issue is related to benchmarking and weights.
Since we print regression test results manually every time, we don't need to use
benchmark_name
insideBenchmarkUsage
. We can just put the name insideprintln!
.polkadot-sdk/polkadot/node/subsystem-bench/src/lib/usage.rs
Lines 24 to 28 in 475e7a1
The text was updated successfully, but these errors were encountered: