Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email HTML should be passed in request body not in URI string #43

Open
jeffpe opened this issue Jul 31, 2019 · 0 comments
Open

Email HTML should be passed in request body not in URI string #43

jeffpe opened this issue Jul 31, 2019 · 0 comments

Comments

@jeffpe
Copy link

jeffpe commented Jul 31, 2019

Ok seems like this was addressed in previous issue from years ago:
https://github.com/Pardot/ruby-pardot/blob/master/lib/pardot/http.rb#L19


If the html content of an email is passed in the URI string, as the gem does, it is limited in length. The gem will fail when this occurs as it does not recognize the error and generates a NIL Error (undefined method '[]' for nil:nilClass in emails.rb:37 from emails.rb:25 ).

Gem should be altered to pass email html in the body of the http request. Note other parameters could be passed this way as well.

Interestingly the Pardot API does return the error in the return URI string (HTTP 414 URI Too Long ) but the gem does not recognize these errors.

I patched with a few quick conditionals. Looks like better fix was posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant