Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: writeSnapshot unicode issue #118

Open
PetroTsapei opened this issue Nov 10, 2022 · 2 comments
Open

Windows: writeSnapshot unicode issue #118

PetroTsapei opened this issue Nov 10, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@PetroTsapei
Copy link

windows backend is not handling non-English paths.

I guess this is happening because you are using std::string for the path string.

@mischnic
Copy link
Member

What exactly is the issue? It's not detecting changes with getEventsSince or does it crash?

@PetroTsapei
Copy link
Author

@mischnic

The error for the code below is Error opening directory

const { writeSnapshot } = require('./index');
const { tmpdir } = require('os');
const { join } = require('path');

writeSnapshot('C:\\Users\\petro\\Desktop\\フォルダーが選択されていません', join(tmpdir(), 'monument-watcher-snapshot'))
.catch((error) => {
  console.log(error)
})

The same code, but only with an English path would work.

@mischnic mischnic added the bug Something isn't working label Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants