sta::make_report_path_attr_field

Signed-off-by: James Cherry <cherry@parallaxsw.com>

Author: jjcherry56

include/sta/Sta.hh

@@ -83,7 +83,8 @@ using CheckErrorSeq = std::vector<CheckError*>;
 enum class CmdNamespace { sta, sdc };
 using ParasiticsNameMap = std::map<std::string, Parasitics*, std::less<>>;
 using GraphLoopSeq = std::vector<GraphLoop*>;
-using ReportFieldGetValue = std::function<std::string (const Path*)>;
+using ReportFieldGetValue = std::function<std::string (const Path *path,
+                                                       const StaState *sta)>;
 
 // Initialize sta functions that are not part of the Sta class.
 void initSta();

network/Network.i

@@ -655,6 +655,15 @@ get_attribute(const char *key)
   return Sta::sta()->ensureLinked()->getAttribute(self, key);
 }
 
+void
+set_attribute(const char *key,
+              const char *value)
+{
+  sta::Sta *sta = Sta::sta();
+  sta->ensureLinked();
+  sta->networkReader()->setAttribute(self, key, value);
+}
+
 } // Instance methods
 
 %extend InstanceChildIterator {
@@ -813,4 +822,3 @@ bool has_next() { return self->hasNext(); }
 const Pin *next() { return self->next(); }
 void finish() { delete self; }
 } // NetConnectedPinIterator methods
-

search/ReportPath.cc

@@ -121,9 +121,10 @@ ReportField::setEnabled(bool enabled)
 }
 
 std::string
-ReportField::value(const Path *path) const
+ReportField::value(const Path *path,
+                   const StaState *sta) const
 {
-  return get_value_(path);
+  return get_value_(path, sta);
 }
 
 ////////////////////////////////////////////////////////////////
@@ -2840,13 +2841,13 @@ ReportPath::reportPath6(const Path *path,
         if (field_fanout_->enabled())
           fanout = drvrFanout(vertex, scene, min_max);
         const std::string what = descriptionField(vertex);
-        reportLine(what, path, cap, slew, fanout,
+        reportLine(what, path1, cap, slew, fanout,
                    incr, field_blank_, time, false, min_max, rf, src_attr,
                    line_case);
 
         if (report_net_) {
           const std::string what2 = descriptionNet(pin);
-          reportLine(what2, path, field_blank_, field_blank_, field_blank_,
+          reportLine(what2, path1, field_blank_, field_blank_, field_blank_,
                      field_blank_, field_blank_, field_blank_, false, min_max,
                      nullptr, src_attr, "");
         }
@@ -2859,7 +2860,7 @@ ReportPath::reportPath6(const Path *path,
             || (i == path_last_index)
             || is_clk_start) {
           const std::string what = descriptionField(vertex);
-          reportLine(what, path, field_blank_, slew, field_blank_,
+          reportLine(what, path1, field_blank_, slew, field_blank_,
                      incr, field_blank_, time, false, min_max, rf, src_attr,
                      line_case);
           prev_time = time;
@@ -3253,7 +3254,7 @@ ReportPath::reportLine(std::string_view what,
       else if (field == field_case_)
         line += line_case;
       else if (field->getValue())
-        line += field->value(path);
+        line += field->value(path, this);
 
       first_field = false;
     }

search/ReportPath.hh

@@ -51,7 +51,8 @@ namespace sta {
 class Scene;
 class PathExpanded;
 
-using ReportFieldGetValue = std::function<std::string (const Path*)>;
+using ReportFieldGetValue = std::function<std::string (const Path *path,
+                                                       const StaState *sta)>;
 
 class ReportField
 {
@@ -76,7 +77,8 @@ public:
   const std::string &blank() const { return blank_; }
   void setEnabled(bool enabled);
   bool enabled() const { return enabled_; }
-  std::string value(const Path *path) const;
+  std::string value(const Path *path,
+                    const StaState *sta) const;
   const ReportFieldGetValue &getValue() const { return get_value_; }
 
 protected:

search/Search.i

@@ -413,15 +413,23 @@ set_report_path_fields(StringSeq fields)
 }
 
 void
-make_report_path_field(const char *name,
-                       const char *name_abrev,
-                       const char *title,
-                       int width,
-                       bool left_justify,
-                       Unit *unit)
-{
-  Sta::sta()->makeReportPathField(name, name_abrev, title, width, left_justify,
-                                  unit, ReportFieldGetValue());
+make_report_path_attr_field(std::string attr_name,
+                            int width)
+{
+  Sta *sta = Sta::sta();
+  sta->makeReportPathField(attr_name, attr_name, attr_name, width, true,
+                           nullptr,
+                           [attr_name] (const Path *path,
+                                        const StaState *sta) -> std::string {
+                             if (path) {
+                               const Network *network = sta->network();
+                               const Pin *pin = path->pin(sta);
+                               const Instance *inst = network->instance(pin);
+                               return network->getAttribute(inst, attr_name);
+                             }
+                             else
+                               return "";
+                           });
 }
 
 const char *

search/Search.tcl

@@ -158,8 +158,6 @@ proc find_timing_paths_cmd { cmd args_var } {
     sta_error 511 "$cmd command failed."
   }
 
-  check_for_key_args $cmd args
-
   if { [info exists flags(-unconstrained)] } {
     set unconstrained 1
   } elseif { [info exists sta_report_unconstrained_paths] } {
@@ -230,7 +228,6 @@ proc find_timing_paths_cmd { cmd args_var } {
       sta_error 515 "positional arguments not supported."
     }
   }
-
   set path_ends [find_path_ends $from $thrus $to $unconstrained \
                    $scenes $min_max \
                    $group_path_count $endpoint_path_count \
@@ -692,7 +689,7 @@ proc parse_report_path_options { cmd args_var default_format
     unset path_options
   }
   parse_key_args $cmd args path_options {-format -digits -fields} \
-    path_options {-no_line_splits} $unknown_key_is_error
+    path_options {-no_line_splits} 1
 
   set format $default_format
   if [info exists path_options(-format)] {