Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove PartialEq+Eq from ProviderError and all others affected #13592

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: remove PartialEq+Eq from ProviderError and all others affected #13592

wants to merge 3 commits into from

Conversation

tnv1
Copy link
Contributor

@tnv1 tnv1 commented Dec 29, 2024

Closes #13584.

mattsse
mattsse reviewed Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, looks like only a few assert_eq -> matches are missing

@tnv1 tnv1 marked this pull request as ready for review January 1, 2025 13:11
@tnv1
Copy link
Contributor Author

tnv1 commented Jan 1, 2025

Hi @mattsse, please check PR again. I'm just fixed issues about lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove PartialEq+Eq from ProviderError
2 participants
@tnv1 @mattsse