Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove PartialEq+Eq from ProviderError #13584

Open
mattsse opened this issue Dec 28, 2024 · 4 comments · May be fixed by #13592
Open

remove PartialEq+Eq from ProviderError #13584

mattsse opened this issue Dec 28, 2024 · 4 comments · May be fixed by #13592
Assignees
@tnv1
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Dec 28, 2024

Describe the feature

this enforces that all other errors are also partialeq+eq, making it difficult to use smth like Box<dyn Error>

reth/crates/storage/errors/src/provider.rs

Lines 12 to 14 in ad89056

/// Bundled errors variants thrown by various providers.
#[derive(Clone, Debug, PartialEq, Eq, thiserror::Error)]
pub enum ProviderError {

TODO

  • remove derive PartialEq+Eq from this error and all others affected
  • update tests where this is used, converting assert_eq! to assert!(matches!())

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Dec 28, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started C-debt Refactor of code section that is hard to understand or maintain and removed S-needs-triage This issue needs to be labelled labels Dec 28, 2024
@tnv1
Copy link
Contributor

tnv1 commented Dec 28, 2024

Hi @mattsse, i would like to take this issue. Thanks

@mattsse
Copy link
Collaborator Author

mattsse commented Dec 28, 2024

assigned, lmk if you encounter any blockers

@VyuduInc
Copy link

Can I take this issue?

@tnv1 tnv1 linked a pull request Dec 29, 2024 that will close this issue
Open
@mymiracle0118
Copy link

Is it okay if I tackle this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tnv1 tnv1

Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove PartialEq+Eq from ProviderError and all others affected tnv1/reth
4 participants
@VyuduInc @mattsse @mymiracle0118 @tnv1