Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a custom error enum for the state root task #13359

Open
mvares opened this issue Dec 12, 2024 · 3 comments
Open

Introduce a custom error enum for the state root task #13359

mvares opened this issue Dec 12, 2024 · 3 comments
Labels
A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain

Comments

@mvares
Copy link
Contributor

mvares commented Dec 12, 2024

Think we should introduce a custom error enum for the state root tas. We seem to abuse the ParallelStateRootError::Other.

Originally posted by @shekhirin in #13356 (comment)
@shekhirin
Copy link
Collaborator

thanks! Do you want me to assign you to this issue?

@shekhirin shekhirin added C-debt Refactor of code section that is hard to understand or maintain A-trie Related to Merkle Patricia Trie implementation labels Dec 13, 2024
@mvares
Copy link
Contributor Author

mvares commented Dec 13, 2024

@shekhirin yes. Btw, where can I create the new enum to these errors?

@mvares
Copy link
Contributor Author

mvares commented Dec 16, 2024

@shekhirin yes. Btw, where can I create the new enum to these errors?

@mattsse what's your opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shekhirin @mvares